Re: [Qemu-devel] [PATCH V17 04/10] libqblock: build: add rule for libqblock.la

[Wenchao Xia]

于 2013-1-31 22:36, Stefan Hajnoczi 写道:
> On Thu, Jan 31, 2013 at 04:53:44PM +0800, Wenchao Xia wrote:
> > diff --git a/libqblock/Makefile b/libqblock/Makefile
> > index 8173da7..a6be721 100644
> > --- a/libqblock/Makefile
> > +++ b/libqblock/Makefile
> > @@ -1,4 +1,29 @@
> >   all: libqblock.la
> >
> > -libqblock.la:
> > -       @true
> > +# objects linked into a shared library, built with libtool with -fPIC if 
> > required
> > +libqblock-obj-y = libqblock/libqblock.o libqblock/libqblock-error.o
> > +libqblock-obj-y += $(filter-out stubs/set-fd-handler.o, $(stub-obj-y))
>
> I guess you will reimplement the function yourself later?  Please
> include a comment explaining the reason for making this exception.

  qemu_set_fd_handler2() in iohandler.c in block-obj-y conflict
with the symbol in stubs/set-fd-handler.c, which can be solved
in qemu-img by linking .a files, but error in linking with .lo
files, so filter it out. Yes, a comment should be added here.



--
Best Regards

Wenchao Xia