[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-1.4 v2] block/raw-posix: Build fix for O_ASY
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH for-1.4 v2] block/raw-posix: Build fix for O_ASYNC |
Date: |
Fri, 1 Feb 2013 15:11:18 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Jan 31, 2013 at 03:40:14PM +0100, Andreas Färber wrote:
> Commit eeb6b45d48800e96f67ef2a5c80332557fd45ddb (block: raw-posix image
> file reopen) broke the build on OpenIndiana.
>
> illumos has no O_ASYNC. Exclude it from flags to be compared
> and instead assert that it is not set where defined.
>
> Cf. e61ab1da7e98357da47c54d8f893b9bd6ff2f7f9 for qemu-ga.
>
> Cc: address@hidden (1.3.x)
> Cc: Jeff Cody <address@hidden>
> Suggested-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Andreas Färber <address@hidden>
> ---
> v1 -> v2:
> * Instead of excluding O_ASYNC from flag comparison only for CONFIG_SOLARIS,
> assert that O_ASYNC is not set if defined. Suggested by Paolo.
>
> block/raw-posix.c | 11 ++++++++++-
> 1 Datei geändert, 10 Zeilen hinzugefügt(+), 1 Zeile entfernt(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH for-1.4 v2] block/raw-posix: Build fix for O_ASYNC,
Stefan Hajnoczi <=