[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-1.4 0/8] -numa option parsing fixes (v3)
From: |
Anthony Liguori |
Subject: |
Re: [Qemu-devel] [PATCH for-1.4 0/8] -numa option parsing fixes (v3) |
Date: |
Fri, 01 Feb 2013 14:45:06 -0600 |
User-agent: |
Notmuch/0.13.2+93~ged93d79 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) |
Eduardo Habkost <address@hidden> writes:
> Ping?
>
> If this is not 1.4 material, it's no problem to me. I just wanted to
> know if this is being ignored because it's too late for 1.4, or because
> it was lost in some black hole.
I would apply this but this thread is a PITA to sort through. You
should do full resubmits of series if you can a patch.
Please resubmit a full v7 series. It's bug fixes so it can go in after -rc0.
Regards,
Anthony Liguori
>
>
> On Mon, Jan 28, 2013 at 02:55:59PM -0200, Eduardo Habkost wrote:
>>
>> I would like to get these bug fixes in 1.4. Who is the right maintainer
>> to pull this in? Anthony?
>>
>> (Note that patch 1/8 has a newer version (v6))
>>
>>
>> On Wed, Jan 16, 2013 at 04:28:45PM -0200, Eduardo Habkost wrote:
>> > Changes v2 -> v3:
>> > - Add 'base' parameter to parse_uint*() (patch 1/8)
>> > - Keep existing base=10 behavior when parsing "nodeid" and "cpus"
>> > (patches 6/8, 8/8)
>> > - Trivial whitespace change on patch 1/8
>> > - Fix fprintf() format string on patch 5/8
>> >
>> > This series contains only the most important fixes from the previous "-numa
>> > option parsing fixes & improvements" series I have submitted.
>> >
>> > I have introduced parse_uint*() helpers that can be reused by other code,
>> > later.
>> > I plan to submit parse_int*() (for signed integers) and parse_double*()
>> > functions too, later, and change string-input-visitor.c and opts-visitor.c
>> > to
>> > use those common functions instead of duplicating the number parsing code.
>> >
>> >
>> > Eduardo Habkost (8):
>> > cutils: unsigned int parsing functions
>> > vl.c: Fix off-by-one bug when handling "-numa node" argument
>> > vl.c: Abort on unknown -numa option type
>> > vl.c: Check for NUMA node limit inside numa_add()
>> > vl.c: numa_add(): Validate nodeid before using it
>> > vl.c: Use parse_uint_full() for NUMA nodeid
>> > vl.c: Extract -numa "cpus" parsing to separate function
>> > vl.c: validate -numa "cpus" parameter properly
>> >
>> > include/qemu-common.h | 4 +
>> > tests/Makefile | 3 +
>> > tests/test-cutils.c | 216
>> > ++++++++++++++++++++++++++++++++++++++++++++++++++
>> > util/cutils.c | 79 ++++++++++++++++++
>> > vl.c | 93 ++++++++++++++++------
>> > 5 files changed, 370 insertions(+), 25 deletions(-)
>> > create mode 100644 tests/test-cutils.c
>> >
>> > --
>> > 1.7.11.7
>> >
>> >
>>
>> --
>> Eduardo
>>
>
> --
> Eduardo
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH for-1.4 0/8] -numa option parsing fixes (v3),
Anthony Liguori <=