[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V3 8/8] hw/mdio: Use bitbang core for smc91c111
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH V3 8/8] hw/mdio: Use bitbang core for smc91c111 network device |
Date: |
Sat, 2 Feb 2013 23:51:42 +0000 |
On 2 February 2013 23:40, Grant Likely <address@hidden> wrote:
> static const VMStateDescription vmstate_smc91c111 = {
> @@ -71,6 +76,8 @@ static const VMStateDescription vmstate_smc91c111 = {
> VMSTATE_BUFFER_UNSAFE(data, smc91c111_state, 0, NUM_PACKETS * 2048),
> VMSTATE_UINT8(int_level, smc91c111_state),
> VMSTATE_UINT8(int_mask, smc91c111_state),
> + VMSTATE_MDIO(mdio_bus, smc91c111_state),
> + VMSTATE_MDIO_PHY(phy, smc91c111_state),
> VMSTATE_END_OF_LIST()
> }
If you're adding vmstate fields to an existing structure
you need to either:
(a) increment the .version_id field, and set .minimum_version_id
field to the same value [and accept that old-to-new migration
won't be possible, which is OK in this particular case as it's
only used by ARM boards and I'm happy that we don't currently
support cross version migration on ARM]
(b) increment .version_id only, mark the new vmstate fields
as only-from-version-N, and cope with what you get if an
incoming migration hasn't got the fields.
For a complicated thing like the phy I would suggest course
(a) as the simplest approach.
-- PMM
- [Qemu-devel] [PATCH V3 0/8] Generalize MDIO framework, Grant Likely, 2013/02/02
- [Qemu-devel] [PATCH V3 1/8] hw/etraxfs_eth: Eliminate checkpatch errors, Grant Likely, 2013/02/02
- [Qemu-devel] [PATCH V3 2/8] hw/mdio: Generalize etraxfs MDIO bitbanging emulation, Grant Likely, 2013/02/02
- [Qemu-devel] [PATCH V3 3/8] hw/mdio: Add PHY register definition, Grant Likely, 2013/02/02
- [Qemu-devel] [PATCH V3 4/8] hw/mdio: Generalize phy initialization routine, Grant Likely, 2013/02/02
- [Qemu-devel] [PATCH V3 5/8] hw/mdio: Mask out read-only bits., Grant Likely, 2013/02/02
- [Qemu-devel] [PATCH V3 7/8] hw/mdio: Add VMState support, Grant Likely, 2013/02/02
- [Qemu-devel] [PATCH V3 8/8] hw/mdio: Use bitbang core for smc91c111 network device, Grant Likely, 2013/02/02
- Re: [Qemu-devel] [PATCH V3 8/8] hw/mdio: Use bitbang core for smc91c111 network device,
Peter Maydell <=
- [Qemu-devel] [PATCH V3 6/8] hw/mdio: Refactor bitbanging state machine, Grant Likely, 2013/02/02
- Re: [Qemu-devel] [PATCH V3 0/8] Generalize MDIO framework, Edgar E. Iglesias, 2013/02/05