Re: [Qemu-devel] [OpenBIOS] Fix double nvram entry on newworld

[Alexander Graf]

Am 03.02.2013 um 15:18 schrieb Anthony Liguori <address@hidden>:

> Alexander Graf <address@hidden> writes:
> 
>> Am 02.02.2013 um 14:05 schrieb Blue Swirl <address@hidden>:
>> 
>>> On Thu, Jan 31, 2013 at 3:10 PM, Alexander Graf <address@hidden> wrote:
>>>> 
>>>> On 30.01.2013, at 11:29, Amadeusz Sławiński wrote:
>>>> 
>>>>> Fix double nvram entry on newworld
>>>>> 
>>>>> There are two nvram entries on newworld (for example qemu -M mac99)
>>>>> 
>>>>> The first one (address@hidden) has initialized .properties while the
>>>>> other one has words.
>>>>> 
>>>>> 0 > dev / ls
>>>>> ...
>>>>> fff75e24 address@hidden
>>>>> fff77848 address@hidden
>>>>> fff778e0 nvram
>>>>> ok
>>>>> 0 > dev /address@hidden  ok
>>>>> 0 > words
>>>>> ok
>>>>> 0 > .properties
>>>>> name                      "nvram"
>>>>> #bytes                    2000
>>>>> reg                       fff04000   00004000
>>>>> device_type               "nvram"
>>>>> compatible                "nvram,flash"
>>>>> ok
>>>>> 0 > dev /address@hidden  ok
>>>>> 0 > words close open seek write read size
>>>>> ok
>>>>> 0 > .properties
>>>>> name                      "nvram"
>>>>> ok
>>>>> 
>>>>> This patch fixes initialization, so only one node is created
>>>>> containing both .properties and words.
>>>>> 
>>>>> 0 > dev / ls
>>>>> ...
>>>>> fff75e24 address@hidden
>>>>> fff77868 address@hidden
>>>>> ok
>>>>> 0 > dev /address@hidden  ok
>>>>> 0 > words close open seek write read size
>>>>> ok
>>>>> 0 > .properties
>>>>> name                      "nvram"
>>>>> #bytes                    2000
>>>>> reg                       fff04000   00004000
>>>>> device_type               "nvram"
>>>>> compatible                "nvram,flash"
>>>>> ok
>>>>> 
>>>>> Signed-off-by: Amadeusz Sławiński <address@hidden>
>>>> 
>>>> Blue, once this patch is in the tree, do you think you could rebuild 
>>>> OpenBIOS for QEMU, so that it will land in 1.4?
>>> 
>>> Sorry, it didn't happen before the freeze. I'm not sure if new
>>> OpenBIOS images qualifies as a bug fix.
>> 
>> I would say yes ;).
>> 
>> Anthony, any objections from your side?
> 
> Nope.

Awesome!

Blue, mind to push new binaries? I'm currently at FOSDEM - not the greatest 
place to do this at ;).


Alex