qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] How many msi-x vectors should be allocated for the virt


From: Paolo Bonzini
Subject: Re: [Qemu-devel] How many msi-x vectors should be allocated for the virtio-serial device?
Date: Mon, 04 Feb 2013 10:42:32 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2

Il 03/02/2013 13:11, Michael S. Tsirkin ha scritto:
>> >  static Property virtio_serial_properties[] = {
>> >      DEFINE_PROP_BIT("ioeventfd", VirtIOPCIProxy, flags, 
>> > VIRTIO_PCI_FLAG_USE_IOEVENTFD_BIT, true),
>> > -    DEFINE_PROP_UINT32("vectors", VirtIOPCIProxy, nvectors, 
>> > DEV_NVECTORS_UNSPECIFIED),
>> > +    DEFINE_PROP_UINT32("vectors", VirtIOPCIProxy, nvectors, 2),
>> >      DEFINE_PROP_HEX32("class", VirtIOPCIProxy, class_code, 0),
>> >      DEFINE_VIRTIO_COMMON_FEATURES(VirtIOPCIProxy, host_features),
>> >      DEFINE_PROP_UINT32("max_ports", VirtIOPCIProxy, 
>> > serial.max_virtserial_ports, 31),
>> > 
>> > plus the backwards-compatibility stuff.
>> > 
>> > Paolo
> Makes sense, but the logic in virtio_serial_init_pci is
> then dead code and should go away.
> 

It won't be dead code for the backwards-compatible machine types (that
use DEV_NVECTORS_UNSPECIFIED).

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]