Re: [Qemu-devel] [PATCH 14/19] hw: use default-configs for more devices instead of hw/ARCH/Makefile.objs

[Andreas Färber]

Am 04.02.2013 18:29, schrieb Paolo Bonzini:
> Other devices are now moved out of hw/ARCH, adding new CONFIG_*
> symbols that let them be included selectively in the emulators.
> The devices however are still compiled in target-specific
> directories.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>

I don't think this is a good idea. For one thing the patch does too many
movements at once for proper commenting. For another you group devices
strictly by busses. And once again this invasive series does not seem to
CC the respective maintainers whose code you move around.

We just had a discussion in the Port I/O context that devices should not
derive according to busses but should have-a bus-specific connector
interface/object from a pure chipset object. That would contradict the
split by bus IMO (but I wasn't the one to call for that).

Also you are moving files like, e.g., sPAPR or ppc4xx into mst's pci/
directory, where he is rather unlikely to do much work on. It would be
more sensible to have sPAPR PHB live alongside other sPAPR devices that
David et al. maintain, say hw/ppc/spapr/. Apart from that I already
commented on the USB movement that, e.g., spapr_pci is more natural to
read than the reversed host-spapr.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg