qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-1.4 2/2] configure: Fix build with XFree


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH for-1.4 2/2] configure: Fix build with XFree
Date: Tue, 05 Feb 2013 07:34:15 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2

On 2013-02-04 23:43, Stefan Weil wrote:
Am 05.02.2013 01:21, schrieb Richard Henderson:
The build is broken on ppc64-linux, possibly only with new binutils:

ld: hw/lm32/../milkymist-tmu2.o: undefined reference to symbol 'XFree'
ld: note: 'XFree' is defined in DSO /lib64/libX11.so.6 so try \
   adding it to the linker command line

So let's follow the linker's advice.

Signed-off-by: Richard Henderson <address@hidden>
---
  configure | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 0657b1a..8789324 100755
--- a/configure
+++ b/configure
@@ -2388,7 +2388,7 @@ fi
  ##########################################
  # opengl probe, used by milkymist-tmu2
  if test "$opengl" != "no" ; then
-  opengl_libs="-lGL"
+  opengl_libs="-lGL -lX11"
    cat > $TMPC << EOF
  #include <X11/Xlib.h>
  #include <GL/gl.h>

What about using pkg-config to probe for opengl and
get the correct linker options? Then static linking would
also be fixed (it needs more than -lX11):

$ pkg-config --libs gl
-lGL
$ pkg-config --libs --static gl
-lGL -lm -lXext -lX11 -lpthread -lxcb -lXau -lXdmcp

(tested on a Debian GNU Linux host)

That's another issue. The issue being fixed here is that XFree isn't in opengl at all, it's in the base X11 library.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]