Re: [Qemu-devel] [PATCH for-1.4 07/12] qemu-char: Fix chardev "memory" not to drop IAC characters

[Eric Blake]

On 02/05/2013 09:22 AM, Markus Armbruster wrote:
> Undocumented misfeature, get rid of it while we can.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  qemu-char.c | 5 -----
>  1 file changed, 5 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

> 
> diff --git a/qemu-char.c b/qemu-char.c
> index 0f91ca4..9460a9d 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -2678,11 +2678,6 @@ static int cirmem_chr_write(CharDriverState *chr, 
> const uint8_t *buf, int len)
>      }
>  
>      for (i = 0; i < len; i++ ) {
> -        /* Avoid writing the IAC information to the queue. */
> -        if ((unsigned char)buf[i] == IAC) {
> -            continue;
> -        }
> -
>          d->cbuf[d->prod++ % d->size] = buf[i];
>          if ((d->prod - d->cons) > d->size) {
>              d->cons = d->prod - d->size;
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature