qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-1.4 09/12] qemu-char: Redo chardev "memory"


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH for-1.4 09/12] qemu-char: Redo chardev "memory" size configuration
Date: Tue, 05 Feb 2013 15:33:46 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2

On 02/05/2013 09:22 AM, Markus Armbruster wrote:
> New device, has never been released, so we can still improve things
> without worrying about compatibility:
> 
> * Rename parameter from maxcapacity to size (simple words are good for
>   you).
> 
> * Clearly mark the parameter as optional in documentation.
> 
> * Support suffixed size arguments like "size=64K",
> 
> * Fix chardev-add to report errors to current monitor, not stderr.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  qemu-char.c     | 11 +++++------
>  qemu-options.hx | 11 ++++-------
>  2 files changed, 9 insertions(+), 13 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]