[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-1.4 02/12] qmp: Clean up design of memchar-r
|
From: |
Luiz Capitulino |
|
Subject: |
Re: [Qemu-devel] [PATCH for-1.4 02/12] qmp: Clean up design of memchar-read |
|
Date: |
Wed, 6 Feb 2013 11:45:51 -0200 |
[Forgot to add Michael, re-sending]
On Tue, 5 Feb 2013 17:22:05 +0100
Markus Armbruster <address@hidden> wrote:
> The data returned has a well-defined size, which makes the size
> returned along with it redundant at best. Drop it.
It was me who asked Lei to add it and the reasons were: 1. qemu-ga
does it too, so it's good to be consistent and 2. I believe this
is good for the QMP as a C interface.
I agree with this change as long as we agree that for now we won't
return a size for returned strings.
- [Qemu-devel] [PATCH for-1.4 00/12] Fix memchar-read/-write before API gets released, Markus Armbruster, 2013/02/05
- [Qemu-devel] [PATCH for-1.4 04/12] qmp: Plug memory leaks in memchar-write, memchar-read, Markus Armbruster, 2013/02/05
- [Qemu-devel] [PATCH for-1.4 03/12] qmp: Clean up type usage in qmp_memchar_write(), qmp_memchar_read(), Markus Armbruster, 2013/02/05
- [Qemu-devel] [PATCH for-1.4 02/12] qmp: Clean up design of memchar-read, Markus Armbruster, 2013/02/05
- [Qemu-devel] [PATCH for-1.4 06/12] qmp: Drop wasteful zero-initialization in qmp_memchar_read(), Markus Armbruster, 2013/02/05
- [Qemu-devel] [PATCH for-1.4 07/12] qemu-char: Fix chardev "memory" not to drop IAC characters, Markus Armbruster, 2013/02/05
- [Qemu-devel] [PATCH for-1.4 05/12] qmp: Drop superfluous special case "empty" in qmp_memchar_read(), Markus Armbruster, 2013/02/05
- [Qemu-devel] [PATCH for-1.4 01/12] qmp: Fix design bug and read beyond buffer in memchar-write, Markus Armbruster, 2013/02/05