[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC V6 05/33] qcow2: Make update_refcount public.
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [RFC V6 05/33] qcow2: Make update_refcount public. |
|
Date: |
Wed, 6 Feb 2013 17:50:49 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Feb 06, 2013 at 01:31:38PM +0100, Benoît Canet wrote:
> /* XXX: cache several refcount block clusters ? */
> -static int QEMU_WARN_UNUSED_RESULT update_refcount(BlockDriverState *bs,
> +int QEMU_WARN_UNUSED_RESULT update_refcount(BlockDriverState *bs,
Public functions are prefixed with qcow2_.
At this point in the series it's also hard to know whether the code
which will call into update_refcount() would better be located in
block/qcow2-refcount.c, keeping update_refcount() static.
- Re: [Qemu-devel] [RFC V6 01/33] qcow2: Add deduplication to the qcow2 specification., (continued)
- [Qemu-devel] [RFC V6 03/33] qcow2: Add deduplication structures and fields., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 04/33] qcow2: Add qcow2_de dup_read_missing_and_concatenate, Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 06/33] qcow2: Create a way to link to l2 tables when deduplicating., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 05/33] qcow2: Make update_refcount public., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 11/33] qcow2: Add qcow2_dedup_grow_table and use it., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 12/33] qcow2: Makes qcow2_alloc_cluster_link_l2 mark to deduplicate clusters., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 17/33] qcow2-cache: Allow to choose table size at creation., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 15/33] qcow2: Load and save deduplication table header extension., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 18/33] qcow2: Extract qcow2_add_feature and qcow2_remove_feature., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 16/33] qcow2: Extract qcow2_do_table_init., Benoît Canet, 2013/02/06