[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC V6 05/33] qcow2: Make update_refcount public.
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC V6 05/33] qcow2: Make update_refcount public. |
Date: |
Wed, 06 Feb 2013 10:49:48 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 02/06/2013 05:31 AM, Benoît Canet wrote:
> Signed-off-by: Benoit Canet <address@hidden>
> ---
> block/qcow2-refcount.c | 6 +-----
> block/qcow2.h | 2 ++
> 2 files changed, 3 insertions(+), 5 deletions(-)
>
> @@ -413,7 +409,7 @@ fail_block:
> }
>
> /* XXX: cache several refcount block clusters ? */
> -static int QEMU_WARN_UNUSED_RESULT update_refcount(BlockDriverState *bs,
> +int QEMU_WARN_UNUSED_RESULT update_refcount(BlockDriverState *bs,
> int64_t offset, int64_t length, int addend)
Fix the indentation while touching this.
> {
> BDRVQcowState *s = bs->opaque;
> diff --git a/block/qcow2.h b/block/qcow2.h
> index 0197a2b..8867091 100644
> --- a/block/qcow2.h
> +++ b/block/qcow2.h
> @@ -396,6 +396,8 @@ int qcow2_update_snapshot_refcount(BlockDriverState *bs,
>
> int qcow2_check_refcounts(BlockDriverState *bs, BdrvCheckResult *res,
> BdrvCheckMode fix);
> +int QEMU_WARN_UNUSED_RESULT update_refcount(BlockDriverState *bs,
> + int64_t offset, int64_t length, int addend);
Indentation is off (second line should start after the '(' of the first
line; wrap to more than two lines if needed).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [RFC V6 03/33] qcow2: Add deduplication structures and fields., (continued)
- [Qemu-devel] [RFC V6 03/33] qcow2: Add deduplication structures and fields., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 04/33] qcow2: Add qcow2_de dup_read_missing_and_concatenate, Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 06/33] qcow2: Create a way to link to l2 tables when deduplicating., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 05/33] qcow2: Make update_refcount public., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 11/33] qcow2: Add qcow2_dedup_grow_table and use it., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 12/33] qcow2: Makes qcow2_alloc_cluster_link_l2 mark to deduplicate clusters., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 17/33] qcow2-cache: Allow to choose table size at creation., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 15/33] qcow2: Load and save deduplication table header extension., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 18/33] qcow2: Extract qcow2_add_feature and qcow2_remove_feature., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 16/33] qcow2: Extract qcow2_do_table_init., Benoît Canet, 2013/02/06