qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH for-1.4 v2 00/13] Rework ring buffer chardev before


From: Markus Armbruster
Subject: [Qemu-devel] [PATCH for-1.4 v2 00/13] Rework ring buffer chardev before API calcifies
Date: Wed, 6 Feb 2013 21:27:13 +0100

We have a serious design bug in memchar-write [PATCH 01], and a less
serious one in memchar-read [PATCH 02].  I really, really want them
fixed before the API gets calcified by the release.

While discussing v1, I mentioned to Luiz how much I dislike the messy
naming, and he encouraged me to fix it up, too.  That's now in [PATCH
11], together with the documentation improvements.

While there, plug memory leaks [PATCH 05], drop undocumented
misfeatures [PATCH 03+08+09], improve device configuration [PATCH 12],
escape control characters in HMP [PATCH 13], and clean up some [other
patches].

v2:
* Patches reordered slightly, to have the new ones all at the end.
* [PATCH 09+12 v1] got squashed with the naming cleanup, and became
  [PATCH 11+12 v2].
* [PATCH 13 v2] is new.  I forgot to include it in v1.
* [PATCH 02+06 v1] screwed up ringbuf-read when size argument actually
  cuts; don't do that.

Markus Armbruster (13):
  qmp: Fix design bug and read beyond buffer in memchar-write
  qmp: Clean up design of memchar-read
  qmp: Use generic errors in memchar-read, memchar-write
  qmp: Clean up type usage in qmp_memchar_write(), qmp_memchar_read()
  qmp: Plug memory leaks in memchar-write, memchar-read
  qmp: Drop superfluous special case "empty" in qmp_memchar_read()
  qmp: Drop wasteful zero-initialization in qmp_memchar_read()
  qemu-char: Fix chardev "memory" not to drop IAC characters
  qemu-char: Drop undocumented chardev "memory" compatibility syntax
  qemu-char: General chardev "memory" code cleanup
  qemu-char: Saner naming of memchar stuff & doc fixes
  qemu-char: Support suffixed ringbuf size arguments like "size=64K"
  hmp: make memchar-read escape ASCII control chars except \n and \t

 hmp-commands.hx  |  39 ++++++++--------
 hmp.c            |  30 +++++++-----
 hmp.h            |   4 +-
 qapi-schema.json |  71 +++++++++++++---------------
 qemu-char.c      | 140 +++++++++++++++++++++++++------------------------------
 qemu-options.hx  |  13 ++----
 qmp-commands.hx  |  61 ++++++++++++------------
 7 files changed, 171 insertions(+), 187 deletions(-)

-- 
1.7.11.7




reply via email to

[Prev in Thread] Current Thread [Next in Thread]