[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH for-1.4 v2 03/13] qmp: Use generic errors in memchar
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH for-1.4 v2 03/13] qmp: Use generic errors in memchar-read, memchar-write |
Date: |
Wed, 6 Feb 2013 21:27:16 +0100 |
New errors should be generic unless there's a real use case for rich
errors.
Signed-off-by: Markus Armbruster <address@hidden>
---
qapi-schema.json | 2 --
qemu-char.c | 4 ++--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/qapi-schema.json b/qapi-schema.json
index d8fa1c3..6f63791 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -352,7 +352,6 @@
# by default is 'utf8'.
#
# Returns: Nothing on success
-# If @device is not a valid char device, DeviceNotFound
#
# Since: 1.4
##
@@ -374,7 +373,6 @@
# memchardev, by default is 'utf8'.
#
# Returns: data read from the device
-# If @device is not a valid memchr device, DeviceNotFound
#
# Since: 1.4
##
diff --git a/qemu-char.c b/qemu-char.c
index b593c50..2bdd1bb 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2764,7 +2764,7 @@ void qmp_memchar_write(const char *device, const char
*data,
chr = qemu_chr_find(device);
if (!chr) {
- error_set(errp, QERR_DEVICE_NOT_FOUND, device);
+ error_setg(errp, "Device '%s' not found", device);
return;
}
@@ -2799,7 +2799,7 @@ char *qmp_memchar_read(const char *device, int64_t size,
chr = qemu_chr_find(device);
if (!chr) {
- error_set(errp, QERR_DEVICE_NOT_FOUND, device);
+ error_setg(errp, "Device '%s' not found", device);
return NULL;
}
--
1.7.11.7
- [Qemu-devel] [PATCH for-1.4 v2 00/13] Rework ring buffer chardev before API calcifies, Markus Armbruster, 2013/02/06
- [Qemu-devel] [PATCH for-1.4 v2 04/13] qmp: Clean up type usage in qmp_memchar_write(), qmp_memchar_read(), Markus Armbruster, 2013/02/06
- [Qemu-devel] [PATCH for-1.4 v2 03/13] qmp: Use generic errors in memchar-read, memchar-write,
Markus Armbruster <=
- [Qemu-devel] [PATCH for-1.4 v2 08/13] qemu-char: Fix chardev "memory" not to drop IAC characters, Markus Armbruster, 2013/02/06
- [Qemu-devel] [PATCH for-1.4 v2 13/13] hmp: make memchar-read escape ASCII control chars except \n and \t, Markus Armbruster, 2013/02/06
- [Qemu-devel] [PATCH for-1.4 v2 07/13] qmp: Drop wasteful zero-initialization in qmp_memchar_read(), Markus Armbruster, 2013/02/06
- [Qemu-devel] [PATCH for-1.4 v2 12/13] qemu-char: Support suffixed ringbuf size arguments like "size=64K", Markus Armbruster, 2013/02/06
- [Qemu-devel] [PATCH for-1.4 v2 06/13] qmp: Drop superfluous special case "empty" in qmp_memchar_read(), Markus Armbruster, 2013/02/06
- [Qemu-devel] [PATCH for-1.4 v2 05/13] qmp: Plug memory leaks in memchar-write, memchar-read, Markus Armbruster, 2013/02/06
- [Qemu-devel] [PATCH for-1.4 v2 10/13] qemu-char: General chardev "memory" code cleanup, Markus Armbruster, 2013/02/06
- [Qemu-devel] [PATCH for-1.4 v2 02/13] qmp: Clean up design of memchar-read, Markus Armbruster, 2013/02/06
- [Qemu-devel] [PATCH for-1.4 v2 01/13] qmp: Fix design bug and read beyond buffer in memchar-write, Markus Armbruster, 2013/02/06
- [Qemu-devel] [PATCH for-1.4 v2 11/13] qemu-char: Saner naming of memchar stuff & doc fixes, Markus Armbruster, 2013/02/06