Re: [Qemu-devel] [PATCH V2 0/3] set config size using available features

[Michael S. Tsirkin]

On Wed, Feb 06, 2013 at 07:45:15PM -0600, Anthony Liguori wrote:
> Jesse Larrew <address@hidden> writes:
> 
> > This patch set fixes an issue with virtio Windows drivers when multiqueue
> > is enabled. This is a narrow fix for 1.4, and I intend to generalize the
> > approach for all virtio devices in 1.5.
> 
> I applied these for -rc1 because I like this better than hard coding the
> old config size.  This is something we're going to have to fix for all
> virtio devices...

Yes, it's a nice, general approach but it does not handle the specific
windows driver bug in all cases :(

See
https://github.com/YanVugenfirer/kvm-guest-drivers-windows/commit/bdf6790a3789156b42ad89d29c4b6d465b02da36

this driver really hard-coded size 32.
So this patch fixes the default config but not the config with status=off.

> However, I also like Michael's patch that gets rid of the mq option so
> Michael, please rebase that patch on top of -rc1 and then we can avoid
> having to explicitly turn mq on.
> 
> Regards,
> 
> Anthony Liguori
> 
> >
> > Changes since V1:
> > * Added missing parentheses around the endof() macro definition.
> > * Fixed spelling errors in the commit message for patch #2.
>