Re: [Qemu-devel] [RFC V6 20/33] qcow2: Add a deduplication boolean to update_refcount.

[Stefan Hajnoczi]

On Wed, Feb 06, 2013 at 01:31:53PM +0100, Benoît Canet wrote:
> @@ -427,7 +427,7 @@ fail_block:
>  
>  /* XXX: cache several refcount block clusters ? */
>  int QEMU_WARN_UNUSED_RESULT update_refcount(BlockDriverState *bs,
> -    int64_t offset, int64_t length, int addend)
> +    int64_t offset, int64_t length, int addend, bool deduplication)

This is a layering violation and is easy to avoid.  More details in
reply to the next patch.

Stefan