Re: [Qemu-devel] [RFC V6 22/33] qcow2: Remove hash when cluster is deleted.

[Stefan Hajnoczi]

On Wed, Feb 06, 2013 at 01:31:55PM +0100, Benoît Canet wrote:
> diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c
> index 4819eb3..1ed219d 100644
> --- a/block/qcow2-dedup.c
> +++ b/block/qcow2-dedup.c
> @@ -942,6 +942,32 @@ int qcow2_dedup_store_new_hashes(BlockDriverState *bs,
>      return ret;
>  }
>  
> +/* Clean the last reference to a given cluster when it's refcount is zero

s/it's/its/

> + *
> + * @cluster_index: the index of the physical cluster
> + */
> +void qcow2_dedup_refcount_zero_reached(BlockDriverState *bs,
> +                                      uint64_t cluster_index)

"refcount zero reached" is the condition under which this function is
called.  It does not describe what the function actually does.

Maybe qcow2_dedup_write_zeroed_hash()?