[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] m25p80.c: Use QOM classes for part differentiat
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH] m25p80.c: Use QOM classes for part differentiation |
Date: |
Thu, 07 Feb 2013 11:40:46 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2 |
Am 07.02.2013 06:51, schrieb Peter Crosthwaite:
> Currently, M25P80 uses an object property to differentiate between flash
> parts.
> Changed this over to use QOM sub-classes - the actual names of the different
> parts
> are used to create a set of dynamic classes which passes the part info as
> class
> data. The object no longer needs to search the known_devices table for itself,
> instead it just gets its info from its own class.
>
> Kept the intermediate class definition private to m25p80.c for the moment, as
> the expectation is parts will only be added as new entries in the table. We
> can
> factor out the TYPE_M25P80 abstraction into a header on a demand basis.
>
> Signed-off-by: Peter Crosthwaite <address@hidden>
Reviewed-by: Andreas Färber <address@hidden>
Looks fine to me except that I would suggest to #define a TYPE_N25Q128
constant. No typos though, so that can be done later.
Cheers,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg