qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC V2 11/16] qcow2: Count deduplication refcount over


From: Eric Blake
Subject: Re: [Qemu-devel] [RFC V2 11/16] qcow2: Count deduplication refcount overflow metric.
Date: Thu, 07 Feb 2013 08:37:17 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2

On 02/06/2013 05:32 AM, Benoît Canet wrote:
> ---
>  block/qcow2-dedup.c |    1 +
>  1 file changed, 1 insertion(+)

It wouldn't hurt to squash several of these one-liner patches into a
bigger patch that turns on collection of all stats in one go.

> 
> diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c
> index e159e77..308b4f6 100644
> --- a/block/qcow2-dedup.c
> +++ b/block/qcow2-dedup.c
> @@ -1024,6 +1024,7 @@ void 
> qcow2_dedup_refcount_half_max_reached(BlockDriverState *bs,
>  
>      /* remove the QCowHashNode from ram so we won't use it anymore for dedup 
> */
>      qcow2_remove_hash_node(bs, hash_node);
> +    s->dedup_metrics.refcount_overflows++;
>  }
>  
>  bool qcow2_dedup_is_running(BlockDriverState *bs)
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]