Re: [Qemu-devel] [PATCH for 1.4] block/vpc: Fix size calculation

[Stefan Hajnoczi]

On Thu, Feb 07, 2013 at 08:26:52PM +0100, Stefan Weil wrote:
> From: Stefan Weil <address@hidden(none)>

Should be "From: Stefan Weil <address@hidden>"?

> The size calculated from the CHS values is not the real image (disk) size,
> but usually a smaller value. This is caused by rounding effects.
> 
> Only older operating systems use CHS. Such guests won't be able to use
> the whole disk. All modern operating systems use the real size.
> 
> This patch fixes https://bugs.launchpad.net/qemu/+bug/1105670/.
> 
> Signed-off-by: Stefan Weil <address@hidden>
> ---
> 
> This is a rebased extract from my patch series for block/vpc.c.
> It's the minimum needed to fix the open bug for QEMU 1.4.
> 
> The rest of the series can be discussed and applied after 1.4.
> 
> Regards
> 
> Stefan W.
> 
> PS. Please excuse a previous personal mail which I had sent
> with a wrong signature and without addressing qemu-devel.
> 
>  block/vpc.c |   14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>