Re: [Qemu-devel] [PATCH 2/2] Add tracepoint for state of migration transition

[Stefan Hajnoczi]

On Wed, Feb 06, 2013 at 03:38:31PM +0900, Kazuya Saito wrote:
> This patch enables us to know state of migration (MigrationState.state)
> transition. We added migstate_set() to make it easier to trace state
> transition, and added a tracepoint in this function.
> 
> 
> Signed-off-by: Kazuya Saito <address@hidden>
> ---
>  include/migration/migration.h |    2 ++
>  migration.c                   |   19 +++++++++++++------
>  trace-events                  |    3 +++
>  3 files changed, 18 insertions(+), 6 deletions(-)
> 
> diff --git a/include/migration/migration.h b/include/migration/migration.h
> index a8c9639..df89e27 100644
> --- a/include/migration/migration.h
> +++ b/include/migration/migration.h
> @@ -132,4 +132,6 @@ int migrate_use_xbzrle(void);
>  int64_t migrate_xbzrle_cache_size(void);
> 
>  int64_t xbzrle_cache_resize(int64_t new_size);
> +
> +void migstate_set(MigrationState *s, int new_state);

I would stick with the common "migrate_" prefix: migrate_set_state().
But it's up to Juan whether it's worth fixing this.

Reviewed-by: Stefan Hajnoczi <address@hidden>