Re: [Qemu-devel] [RFC V6 26/33] qcow2: Add verification of dedup table.

[Stefan Hajnoczi]

On Wed, Feb 06, 2013 at 01:31:59PM +0100, Benoît Canet wrote:
> Signed-off-by: Benoit Canet <address@hidden>
> ---
>  block/qcow2-refcount.c |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
> index f6a80db..d7d9339 100644
> --- a/block/qcow2-refcount.c
> +++ b/block/qcow2-refcount.c
> @@ -1154,6 +1154,14 @@ int qcow2_check_refcounts(BlockDriverState *bs, 
> BdrvCheckResult *res,
>          goto fail;
>      }
>  
> +    if (s->has_dedup) {
> +        ret = check_refcounts_l1(bs, res, refcount_table, nb_clusters,
> +                                 s->dedup_table_offset, s->dedup_table_size, 
> 0);

This doesn't really work because you introduce custom dedup table entry
flags.  It's very dodgy to call check_refcounts_l1() on a table that is
not an L1 table :).

Stefan