Re: [Qemu-devel] Char flow control patches

[Amit Shah]

On (Wed) 30 Jan 2013 [08:38:50], Anthony Liguori wrote:
> Amit Shah <address@hidden> writes:
> 
> > Hi Anthony,
> >
> > I did some basic testing of the char flow control patches from your
> > char-flow.2 branch.  With the following patch applied, things seem to
> > be working fine.  I tested the isa-serial and virtio-serial devices.
> >
> > I haven't yet tested with virtio-serial flow control, but at least no
> > regressions as of now.
> 
> Awesome!

Well -- just tested starting sockets in non-server mode, and that
fails with:

(process:922): GLib-CRITICAL **: g_io_channel_write_chars: assertion `channel 
!= NULL' failed

cmdline:

./x86_64-softmmu/qemu-system-x86_64 -m 512 /guests/f14-nolvm.qcow2 \
  -snapshot -enable-kvm   -chardev socket,path=/tmp/foo,id=foo \
  -device virtio-serial -device virtserialport,chardev=foo,nr=2 \
  -monitor stdio

on the host, also start a listening process, like:

$ socat UNIX-LISTEN:/tmp/foo  -

and doing 'echo foo > /dev/vport0p2' in the guest results in the error
message above.

                Amit