[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-1.4 RESEND v2 1/2] qtest: Use strtoull() for
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH for-1.4 RESEND v2 1/2] qtest: Use strtoull() for uint64_t |
Date: |
Mon, 11 Feb 2013 17:46:05 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2 |
Am 11.02.2013 17:41, schrieb Andreas Färber:
> On 32-bit hosts, unsigned long may be uint32_t and uint64_t may be
> unsigned long long. Account for this by always using strtoull().
> We were already using strtoll() for int64_t.
>
> Signed-off-by: Andreas Färber <address@hidden>
Sorry, this one was
Reviewed-by: Anthony Liguori <address@hidden>
Andreas
> ---
> qtest.c | 8 ++++----
> 1 Datei geändert, 4 Zeilen hinzugefügt(+), 4 Zeilen entfernt(-)
>
> diff --git a/qtest.c b/qtest.c
> index b7a3821..4663a38 100644
> --- a/qtest.c
> +++ b/qtest.c
> @@ -282,8 +282,8 @@ static void qtest_process_command(CharDriverState *chr,
> gchar **words)
> uint8_t *data;
>
> g_assert(words[1] && words[2]);
> - addr = strtoul(words[1], NULL, 0);
> - len = strtoul(words[2], NULL, 0);
> + addr = strtoull(words[1], NULL, 0);
> + len = strtoull(words[2], NULL, 0);
>
> data = g_malloc(len);
> cpu_physical_memory_read(addr, data, len);
> @@ -302,8 +302,8 @@ static void qtest_process_command(CharDriverState *chr,
> gchar **words)
> size_t data_len;
>
> g_assert(words[1] && words[2] && words[3]);
> - addr = strtoul(words[1], NULL, 0);
> - len = strtoul(words[2], NULL, 0);
> + addr = strtoull(words[1], NULL, 0);
> + len = strtoull(words[2], NULL, 0);
>
> data_len = strlen(words[3]);
> if (data_len < 3) {
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg