Re: [Qemu-devel] [PATCH 01/10] mips-linux-user: Delete n32 and n64 signal stubs

[Andreas Färber]

Am 11.02.2013 17:02, schrieb Richard Henderson:
> On 2013-02-10 10:30, Richard Henderson wrote:
>> Signed-off-by: Richard Henderson <address@hidden>
> 
> Deleting these first makes the next patch much easier to read.
> This doesn't cause any sort of compilation failure because we
> have not yet enabled n32/n64 compilation.  This is dead code.

We have it enabled for openSUSE despite the #warning (anyone can enable
it via --target-list, so it's not entirely dead code), but since you're
fixing it later in the series that seems fine with me. Ideally you could
squash patches 1+2 so that there is no regression.

I'll try putting these into our package's patch queue later today.
Thanks for working on fixing this!

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg