[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/10] mipsn32-linux-user: Restrict address spac
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH 09/10] mipsn32-linux-user: Restrict address space to 31-bits. |
|
Date: |
Mon, 11 Feb 2013 17:58:40 +0000 |
On 11 February 2013 17:56, Richard Henderson <address@hidden> wrote:
> On 2013-02-11 09:44, Peter Maydell wrote:
>> Maybe clearer to pull out the "#if HOST_LONG_BITS == 64" into
>> its own #if rather than having it as an && term in both the #if
>> and the #elif?
>
>
> In which case you get two "base" (unsigned long reserved_va;) cases, which
> didn't look clearer at all. The only other thing I can think to do is
>
> #if HLB == 64
> # if MIPS
> # define RESERVED_MAX 0x7f000000
> # elif TLB == 32
> # define RESERVED_MAX 0xf7000000
> # endif
> #endif
> #ifndef RESERVED_MAX
> # define RESERVED_MAX 0
> #endif
>
> unsigned long reserved_va = RESERVED_MAX;
I think that does look better. As I say, I don't feel
very strongly though.
-- PMM
- Re: [Qemu-devel] [PATCH 04/10] mips-linux-user: Save and restore fpu and dsp from sigcontext, (continued)
[Qemu-devel] [PATCH 08/10] target-mips: Fix check_cp1_64bitmode, Richard Henderson, 2013/02/10
[Qemu-devel] [PATCH 07/10] mips64-linux-user: Use MIPS64R2-generic as default cpu., Richard Henderson, 2013/02/10
[Qemu-devel] [PATCH 09/10] mipsn32-linux-user: Restrict address space to 31-bits., Richard Henderson, 2013/02/10
[Qemu-devel] [PATCH 10/10] mipsn32-linux-user: Configure the architecture properly, Richard Henderson, 2013/02/10
Re: [Qemu-devel] [PATCH 00/10] Support mips64/mipsn32-linux-user, Peter Maydell, 2013/02/11