[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH for-next v3 1/5] tmp105-test: Combine assertions of
From: |
Andreas Färber |
Subject: |
[Qemu-devel] [PATCH for-next v3 1/5] tmp105-test: Combine assertions of 16-bit responses |
Date: |
Mon, 11 Feb 2013 20:01:18 +0100 |
From: Andreas Färber <address@hidden>
Instead of comparing bytes individually, compare the full values.
This aids spotting endianness issues.
Signed-off-by: Andreas Färber <address@hidden>
---
tests/tmp105-test.c | 8 ++++----
1 Datei geändert, 4 Zeilen hinzugefügt(+), 4 Zeilen entfernt(-)
diff --git a/tests/tmp105-test.c b/tests/tmp105-test.c
index a6ad213..a1fe99e 100644
--- a/tests/tmp105-test.c
+++ b/tests/tmp105-test.c
@@ -40,16 +40,16 @@ static void send_and_receive(void)
cmd[2] = 0x34;
i2c_send(i2c, addr, cmd, 3);
i2c_recv(i2c, addr, resp, 2);
- g_assert_cmphex(resp[0], ==, cmd[1]);
- g_assert_cmphex(resp[1], ==, cmd[2]);
+ g_assert_cmphex(((uint16_t)resp[0] << 8) | resp[1], ==,
+ ((uint16_t)cmd[1] << 8) | cmd[2]);
cmd[0] = TMP105_REG_T_HIGH;
cmd[1] = 0x42;
cmd[2] = 0x31;
i2c_send(i2c, addr, cmd, 3);
i2c_recv(i2c, addr, resp, 2);
- g_assert_cmphex(resp[0], ==, cmd[1]);
- g_assert_cmphex(resp[1], ==, cmd[2]);
+ g_assert_cmphex(((uint16_t)resp[0] << 8) | resp[1], ==,
+ ((uint16_t)cmd[1] << 8) | cmd[2]);
}
int main(int argc, char **argv)
--
1.7.10.4