Re: [Qemu-devel] [PATCH 4/6] qemu-log: Rename the public-facing cpu_set_log function to qemu_set_log

[Andreas Färber]

Am 11.02.2013 17:41, schrieb Peter Maydell:
> Rename the public-facing function cpu_set_log to qemu_set_log. This
> requires us to rename the internal-only qemu_set_log() to
> do_qemu_set_log().
> 
> Signed-off-by: Peter Maydell <address@hidden>
> ---
>  bsd-user/main.c         |    2 +-
>  cpus.c                  |    2 +-
>  hw/ppc.c                |    2 +-
>  include/qemu/log.h      |   12 ++++++++----
>  linux-user/main.c       |    2 +-
>  monitor.c               |    2 +-
>  qemu-log.c              |    4 ++--
>  target-i386/translate.c |    2 +-
>  tcg/tci/tcg-target.c    |    2 +-
>  9 files changed, 17 insertions(+), 13 deletions(-)
[...]
> diff --git a/hw/ppc.c b/hw/ppc.c
> index c52e22f..6053bd5 100644
> --- a/hw/ppc.c
> +++ b/hw/ppc.c
> @@ -1189,7 +1189,7 @@ void PPC_debug_write (void *opaque, uint32_t addr, 
> uint32_t val)
>          break;
>      case 2:
>          printf("Set loglevel to %04" PRIx32 "\n", val);
> -        cpu_set_log(val | 0x100);
> +        qemu_set_log(val | 0x100);
>          break;
>      }
>  }

I haven't the foggiest what this magic number is about, did you find out?

But since it's only a mechanical renaming,

Reviewed-by: Andreas Färber <address@hidden>

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg