Re: [Qemu-devel] [PATCH v10 4/4] qemu-iotests: Add qemu-img compare test

[Kevin Wolf]

Am 12.02.2013 08:00, schrieb Miroslav Rezanina:
> Simple test for qemu-img compare to check it's working correctly.
> 
> Signed-off-by: Miroslav Rezanina <address@hidden>
> ---
>  tests/qemu-iotests/048     |   77 
> ++++++++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/048.out |   25 ++++++++++++++
>  tests/qemu-iotests/group   |    1 +
>  3 files changed, 103 insertions(+), 0 deletions(-)
>  create mode 100755 tests/qemu-iotests/048
>  create mode 100644 tests/qemu-iotests/048.out
> 
> diff --git a/tests/qemu-iotests/048 b/tests/qemu-iotests/048
> new file mode 100755
> index 0000000..876653e
> --- /dev/null
> +++ b/tests/qemu-iotests/048
> @@ -0,0 +1,77 @@
> +#!/bin/bash
> +##
> +## qemu-img compare test
> +##
> +##
> +## Copyright (C) 2013 Red Hat, Inc.
> +##
> +## This program is free software; you can redistribute it and/or modify
> +## it under the terms of the GNU General Public License as published by
> +## the Free Software Foundation; either version 2 of the License, or
> +## (at your option) any later version.
> +##
> +## This program is distributed in the hope that it will be useful,
> +## but WITHOUT ANY WARRANTY; without even the implied warranty of
> +## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +## GNU General Public License for more details.
> +##
> +## You should have received a copy of the GNU General Public License
> +## along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +##
> +#
> +# creator
> address@hidden
> +
> +seq=`basename $0`
> +echo "QA output created by $seq"
> +
> +status=1        # failure is the default!
> +
> +_cleanup()
> +{
> +    echo "Cleanup"
> +    _cleanup_test_img
> +}
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +_compare()
> +{
> +    $QEMU_IMG compare "$@" $TEST_IMG ${TEST_IMG2}

Maybe add an "echo $?" to check the exit codes?

> +}
> +
> +# get standard environment, filters and checks
> +. ./common.rc
> +. ./common.filter
> +. ./common.pattern
> +
> +_supported_fmt raw qcow qcow2 qed
> +_supported_proto file
> +_supported_os Linux
> +
> +# Setup test basic parameters
> +TEST_IMG2=$TEST_IMG.2
> +CLUSTER_SIZE=4096
> +size=1024M
> +
> +_make_test_img $size
> +io_pattern write 524288 $CLUSTER_SIZE $CLUSTER_SIZE 4 45
> +
> +# Compare identical images
> +cp $TEST_IMG ${TEST_IMG2}
> +_compare
> +_compare -q
> +
> +# Compare images with different size
> +$QEMU_IMG resize $TEST_IMG +512M
> +_compare
> +_compare -s
> +
> +# Compare images with different content
> +io_pattern write 1228800 $CLUSTER_SIZE 0 1 67
> +_compare
> +io_pattern write 0 $CLUSTER_SIZE 0 1 123
> +_compare
> +
> +# Cleanup
> +rm ${TEST_IMG2}

It would be better to move to _cleanup() so that Ctrl-C won't leave the
image behind.

Kevin