Re: [Qemu-devel] [RFC PATCH RDMA support v2: 3/6] install new monitor commands and setup RDMA capabilities

[Michael R Hines]

Acknowledged.

/*
 * Michael R. Hines
 * http://researcher.ibm.com/person/us-mrhines
 */

From:	Eric Blake <address@hidden>
To:	"Michael R. Hines" <address@hidden>,
Cc:	address@hidden, Anthony Liguori/Austin/address@hidden, Bulent Abali/Watson/address@hidden, Michael R Hines/Watson/address@hidden, Gokul B Kandiraju/Watson/address@hidden
Date:	02/12/2013 12:11 PM
Subject:	Re: [Qemu-devel] [RFC PATCH RDMA support v2: 3/6] install new monitor commands and setup RDMA capabilities

---

On 02/11/2013 08:06 PM, Michael R. Hines wrote:

[no need to top-post on a technical list]

> None of the other migration QMP commands use dashes.

Then how do you explain 'query-migrate', 'migrate-set-capabilities',
'query-migrate-capabilities', 'migrate-set-cache-size',
'query-migrate-cache-size'?  I argue that 'migrate_cancel' and
'migrate_set_downtime' are the odd ones out, and only because they were
written before our current policy of preferring dash.

> Shouldn't I stay consistent with the other commands?

Yes, which is why I'm arguing for using dash.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[attachment "signature.asc" deleted by Michael R Hines/Watson/IBM]