Re: [Qemu-devel] kvm segfaulting

[Stefan Priebe - Profihost AG]

Hi,

no VM crashed this morning.

Stefan

Am 13.02.2013 16:24, schrieb Paolo Bonzini:
> Il 13/02/2013 15:30, Stefan Priebe - Profihost AG ha scritto:
>> I added this:
>> -trace events=/tmp/events,file=/root/qemu.123.trace
>>
>> and put the events in the events file as i couldn't handle \n in my app
>> starting the kvm process. But even when doing an fstrim the trace file
>> stays at 24 bytes - is this correct?
> 
> Right... it would eventually flush, but not if qemu-kvm crash.
> 
> Answering your other question, the patch subsumes the other.  But if the
> provisioning mode is writesame_16, this hunk alone will most likely fix
> the crash:
> 
> diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
> index d411586..4a0673c 100644
> --- a/hw/scsi-disk.c
> +++ b/hw/scsi-disk.c
> @@ -178,6 +178,9 @@ static void scsi_aio_complete(void *opaque, int ret)
>      assert(r->req.aiocb != NULL);
>      r->req.aiocb = NULL;
>      bdrv_acct_done(s->qdev.conf.bs, &r->acct);
> +    if (r->req.io_canceled) {
> +        goto done;
> +    }
> 
>      if (ret < 0) {
>          if (scsi_handle_rw_error(r, -ret)) {
> 
> Paolo
>