Re: [Qemu-devel] [PATCH] Fix conversion between 12 hours and 24 hours modes.

[Peter Maydell]

On 14 February 2013 11:44, Andreas Färber <address@hidden> wrote:
> Am 14.02.2013 12:32, schrieb Peter Maydell:
>> On 14 February 2013 11:29, Andreas Färber <address@hidden> wrote:
>>> I may be repeating myself here, but adding qtests as requested would've
>>> caught this.
>>
>> Er, only if the tests were testing for the right thing,
>> which seems unlikely since you can't run a qtest against
>> real hardware. What seems more likely is that we would
>> have written a qtest which checked for the same wrong
>> behaviour we incorrectly put into the code, which
>> doesn't help anybody.
>
> Still my point is we should stop accepting RTC bugfixes without test
> cases or we'll never get things testable... Paolo and me can't write the
> qtests for everyone, that doesn't scale.

I'm not saying "test cases are bad", I'm just saying I think
you're wrong when you claim "test cases would have made us
notice the need for this bugfix".

-- PMM