Re: [Qemu-devel] [RFC PATCH 04/10] qemu-ga: Add Windows VSS provider to quiesce applications on fsfreeze

[Tomoki Sekiyama]

Hi Paolo, thanks for your review.

On 2013/02/14 22:22, Paolo Bonzini wrote:> Il 14/02/2013 07:10, Tomoki
Sekiyama ha scritto:
>> diff --git a/qga/vss-win32-provider/Makefile
b/qga/vss-win32-provider/Makefile
>> new file mode 100644
>> index 0000000..1f213f2
>> --- /dev/null
>> +++ b/qga/vss-win32-provider/Makefile
>> @@ -0,0 +1,30 @@
>> +-include ../../config-host.mak
>> +-include ../../rules.mak
>
> Please try to use a non-recursive makefile style.  See
> libcacard/Makefile for an example.

OK.

>> +# To build .tlb from .idl, WindowsSDK and C++ must be installed
>> +MIDL=midl
>> +WINSDK="C:\\Program Files\\Microsoft SDKs\\Windows\\v7.1\\Include"
>
> When cross-compiling, does it work to use Wine's widl implementation?
> widl needs a "-t" flag when creating a .tlb, but otherwise should be
> compatible.  And unlike some other wine tools, it has no dependency on
> the Wine runtime.
>
> It would be great to choose between midl or widl in configure.  It's
> okay to require a specific option (like --midl=FOO) when compiling under
> Windows, and to require installation of Wine tools to build the VSS
> stuff under non-Windows.

I see. I am not sure whether this works without importlib line,
but if it does, I will add the configuration for use widl.

Thanks,
-- 
Tomoki Sekiyama