qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 4/5] milkymist-softusb: Don't map RAM memory reg


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 4/5] milkymist-softusb: Don't map RAM memory regions in the device itself
Date: Fri, 15 Feb 2013 17:18:56 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2

Il 15/02/2013 17:17, Peter Maydell ha scritto:
> But these memory regions belong to this device -- we own them and
> they won't go away until the device is destroyed [which is never,
> as it happens, for this device.] More generally, if it's valid
> for us to hold a MemoryRegion* and call memory_region_get_ram_ptr()
> in the read/write function, it's just as valid to keep the ram pointer:
> the two have exactly matching lifetimes, unless I'm missing something.

No, you're not: "In practice it should be handled just fine by reference
counting, but I still find it harder to wrap my head around it".

> (as an aside, memory_region_destroy() doesn't free the memory that
> memory_region_init_ram() allocates.)

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]