Re: [Qemu-devel] [PATCH V23 4/7] Build the TPM frontend code

[Stefan Berger]

On 02/16/2013 06:19 AM, Andreas Färber wrote:
> Am 15.02.2013 20:39, schrieb Stefan Berger:
>   if test "$sdl_too_old" = "yes"; then
>   echo "-> Your SDL version is too old - please upgrade to have SDL support"
> @@ -4251,6 +4256,12 @@ if test "$gprof" = "yes" ; then
>     fi
>   fi
>   
> +if test "$tpm" = "yes"; then
> +  if test "$target_softmmu" = "yes" ; then
> +    echo "CONFIG_TPM=y" >> $config_host_mak
> +  fi
> +fi
> So if some softmmu is being built and --enabled-tpm was chosen, we set
> CONFIG_TPM=y for the host. Fine.
>
> > +
> >   if test "$ARCH" = "tci"; then
> >     linker_script=""
> >   else
> > diff --git a/tpm/Makefile.objs b/tpm/Makefile.objs
> > index dffb567..63bfcea 100644
> > --- a/tpm/Makefile.objs
> > +++ b/tpm/Makefile.objs
> > @@ -1 +1,2 @@
> >   common-obj-y = tpm.o
> > +common-obj-$(CONFIG_TPM) += tpm_tis.o
> Some softmmus might not even support ISA, so this needs to be
> conditional on more than just the host's $(CONFIG_TPM), it should be a
> combination of the host's CONFIG_TPM=y and CONFIG_TPM_TIS=y in
> default-configs/{i386,x86_64}-softmmu.config or similar.

I need some help with this... From what I can see at least in hw/Makefile.objs 
isa-bus.o is unconditionally added to common-obj-y. Similarly the sb16.c, also 
an ISA device, ends up in config-host.mak. Does this imply that any softmmu 
will have isa-bus.o and sb16 compile in ?

Regards,
   Stefan