Re: [Qemu-devel] [PATCH for-1.5 0/8] virtio-blk refactoring.

[KONRAD Frédéric]

On 11/02/2013 10:37, address@hidden wrote:
> From: KONRAD Frederic <address@hidden>
>
> This is the next part of virtio-refactoring.
>
> I send it now to have it reviewed.
>
> Basically it creates virtio-blk device which extends virtio-device.
> Then a virtio-blk can be connected on a virtio-bus.
> virtio-blk-pci, virtio-blk-s390x, virtio-blk-ccw are created too, they extend
> respectively virtio-pci, virtio-s390-device, virtio-ccw-device and have a
> virtio-blk.
>
> It is on top of "virtio: make virtio device's structures public" I posted
> before, but you can checkout my branch here:
>
> git://git.greensocs.com/qemu_virtio.git virtio-blk-v4
>
> I made basic tests (with linux guests) on:
>   * qemu-system-i386
>   * qemu-system-s390x
>
> I didn't test dataplane as I don't know how it works? Depends on linux AIO?
>
> Stefan can you try launching dataplane with my tree?
>
> I didn't test virtio-ccw as I don't have the hardware.
>
> Anyone can try it on ccw hardware?
>
> Thanks.
>
> Fred
>
> Changes V3 -> V4:
>    * Added virtio-ccw.
>    * Removed virtio-blk-init/exit from virtio.h
>
> KONRAD Frederic (8):
>    virtio-blk: don't use pointer for configuration.
>    virtio-blk: add the virtio-blk device.
>    virtio-blk-pci: switch to new API.
>    virtio-blk-s390: switch to the new API.
>    virtio-blk-ccw switch to new API.
>    virtio-blk: cleanup: init and exit functions.
>    virtio-blk: cleanup: QOM cast
>    virtio-blk: cleanup: remove qdev field.
>
>   hw/s390x/s390-virtio-bus.c |  30 +++++++----
>   hw/s390x/s390-virtio-bus.h |  13 ++++-
>   hw/s390x/virtio-ccw.c      |  38 ++++++++-----
>   hw/s390x/virtio-ccw.h      |  14 ++++-
>   hw/virtio-blk.c            | 131 +++++++++++++++++++++++++++++----------------
>   hw/virtio-blk.h            |  33 ++++++++++--
>   hw/virtio-pci.c            | 124 +++++++++++++++++++-----------------------
>   hw/virtio-pci.h            |  15 +++++-
>   hw/virtio.h                |   2 -
>   9 files changed, 251 insertions(+), 149 deletions(-)
Is this ok, for everybody?

I did basic test with x86 guest and s390x,
Cornelia reported that it works for CCW too.

I can't test dataplane as it seems not to work with TCG.

Thanks,
Fred