Re: [Qemu-devel] [PATCH v2] qemu-log: default to stderr for logging output

[Markus Armbruster]

Peter Maydell <address@hidden> writes:

> Switch the default for qemu_log logging output from "/tmp/qemu.log"
> to stderr. This is an incompatible change in some sense, but logging
> is mostly used for debugging purposes so it shouldn't affect production
> use. The previous behaviour can be obtained by adding "-D /tmp/qemu.log"
> to the command line.
>
> This change requires us to:
>  * update all the documentation/help text (we take the opportunity
>    to smooth out minor inconsistencies between the phrasing in
>    linux-user/bsd-user/system help messages)
>  * make linux-user and bsd-user defer to qemu-log for the default
>    logging destination rather than overriding it themselves
>  * ensure that all logfile closing is done via qemu_log_close()
>    and that that function doesn't close stderr
> as well as the obvious change to the behaviour of do_qemu_set_log()
> when no logfile name has been specified.
>
> Signed-off-by: Peter Maydell <address@hidden>

Reviewed-by: Markus Armbruster <address@hidden>