Re: [Qemu-devel] [PATCH moxie 3/5] moxie target code

[Andreas Färber]

Am 14.02.2013 12:23, schrieb Andreas Färber:
> Please take a look at the patches queued on qom-cpu-next for the next
> merge window:
> https://github.com/afaerber/qemu-cpu/commits/qom-cpu-next
> You should rebase on that (then using [PATCH qom-cpu-next n/m] or [PATCH
> qom-cpu n/m]) and change cpu_moxie_init() accordingly so that it sets
> realized = true and doesn't do CPU reset, vCPU init or TCG
> initialization from there and move the remaining cpu_moxie_init() to
> your cpu.c.

This is now in qemu.git master, so no need to rebase on my branches any
more.

[...]
> You don't implement migration support (no CPU_SAVE_VERSION in cpu.h at
> least), so please set dc->vmsd to a VMStateDescription marked as
> unmigratable, as done for virtually all such targets for 1.4. Please
> drop machine.c if you don't #define CPU_SAVE_VERSION, this bug was
> recently fixed:
> http://git.qemu.org/?p=qemu.git;a=commit;h=3ce8b2bcbff6445f84db53ef38dbc4e5dd102676
[snip]

Just CC'ed you on a patch series discussing how to proceed with
migration support for new targets such as yours, in case you intend to
implement it later.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg