Re: [Qemu-devel] [PATCH v1 5/6] a9mpcore: remove old_timer_status field

[Peter Crosthwaite]

On Tue, Feb 19, 2013 at 4:40 AM, Peter Maydell <address@hidden> wrote:
> On 8 February 2013 04:03, Peter Crosthwaite
> <address@hidden> wrote:
>> This field was write only and thus unused. Removed.
>>
>> Signed-off-by: Peter Crosthwaite <address@hidden>
>> @@ -198,11 +194,10 @@ static int a9mp_priv_init(SysBusDevice *dev)
>>
>>  static const VMStateDescription vmstate_a9mp_priv = {
>>      .name = "a9mpcore_priv",
>> -    .version_id = 2,
>> -    .minimum_version_id = 1,
>> +    .version_id = 3,
>> +    .minimum_version_id = 2,
>>      .fields = (VMStateField[]) {
>>          VMSTATE_UINT32(scu_control, A9MPPrivState),
>> -        VMSTATE_UINT32_ARRAY(old_timer_status, A9MPPrivState, 8),
>>          VMSTATE_UINT32_V(scu_status, A9MPPrivState, 2),
>>          VMSTATE_END_OF_LIST()
>>      }
>
> Does v2 to v3 migration really work (ie ignoring the
> v2-only field)? Since the previous patch broke migration
> for A9 platforms anyway you might as well set the minimum
> version ID to 3 and save me having to figure out the answer :-)
>

+1. Ill keep it simple with 3/3

> -- PMM
>