Re: [Qemu-devel] [PATCH 10/19] char: add gio watch fn for tcp backends

[Amit Shah]

On (Tue) 19 Feb 2013 [07:55:36], Anthony Liguori wrote:
> Amit Shah <address@hidden> writes:
> 
> > On (Mon) 18 Feb 2013 [15:48:07], Anthony Liguori wrote:
> >> From: Amit Shah <address@hidden>
> >> 
> >> Signed-off-by: Amit Shah <address@hidden>
> >> ---
> >>  qemu-char.c | 7 +++++++
> >>  1 file changed, 7 insertions(+)
> >> 
> >> diff --git a/qemu-char.c b/qemu-char.c
> >> index e59e580..160bcea 100644
> >> --- a/qemu-char.c
> >> +++ b/qemu-char.c
> >> @@ -2462,6 +2462,12 @@ static ssize_t tcp_chr_recv(CharDriverState *chr, 
> >> char *buf, size_t len)
> >>  }
> >>  #endif
> >>  
> >> +static GSource *tcp_chr_add_watch(CharDriverState *chr, GIOCondition cond)
> >> +{
> >> +    TCPCharDriver *s = chr->opaque;
> >> +    return g_io_create_watch(s->chan, cond);
> >
> > Thanks for noticing and fixing this up!
> 
> It an amazing amount of luck that the previous code worked but the
> struct layouts just happened to match :-)

Heh, yeah.  Had it not been for that luck, I'd have noticed it
easily :-)

                Amit