[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 4/6] qcow2: flush in qcow2_update_snapshot_refcount(
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 4/6] qcow2: flush in qcow2_update_snapshot_refcount() |
Date: |
Tue, 19 Feb 2013 16:45:04 +0100 |
Users of qcow2_update_snapshot_refcount() do not flush consistently.
qcow2_snapshot_create() flushes but qcow2_snapshot_goto() and
qcow2_snapshot_delete() do not.
Solve this by moving the bdrv_flush() into
qcow2_update_snapshot_refcount().
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
block/qcow2-refcount.c | 2 +-
block/qcow2-snapshot.c | 5 -----
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index 4ef3dac..df29187 100644
--- a/block/qcow2-refcount.c
+++ b/block/qcow2-refcount.c
@@ -841,7 +841,7 @@ int qcow2_update_snapshot_refcount(BlockDriverState *bs,
}
}
- ret = 0;
+ ret = bdrv_flush(bs);
fail:
if (l2_table) {
qcow2_cache_put(bs, s->l2_table_cache, (void**) &l2_table);
diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c
index 429bbff..d433937 100644
--- a/block/qcow2-snapshot.c
+++ b/block/qcow2-snapshot.c
@@ -378,11 +378,6 @@ int qcow2_snapshot_create(BlockDriverState *bs,
QEMUSnapshotInfo *sn_info)
goto fail;
}
- ret = bdrv_flush(bs);
- if (ret < 0) {
- goto fail;
- }
-
/* Append the new snapshot to the snapshot list */
new_snapshot_list = g_malloc((s->nb_snapshots + 1) * sizeof(QCowSnapshot));
if (s->snapshots) {
--
1.8.1.2
- [Qemu-devel] [PATCH 0/6] qcow2: cache flush fixes and performance improvements, Stefan Hajnoczi, 2013/02/19
- [Qemu-devel] [PATCH 1/6] qcow2: flush refcount cache correctly in alloc_refcount_block(), Stefan Hajnoczi, 2013/02/19
- [Qemu-devel] [PATCH 4/6] qcow2: flush in qcow2_update_snapshot_refcount(),
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 2/6] qcow2: flush refcount cache correctly in qcow2_write_snapshots(), Stefan Hajnoczi, 2013/02/19
- [Qemu-devel] [PATCH 5/6] qcow2: drop flush in update_cluster_refcount(), Stefan Hajnoczi, 2013/02/19
- [Qemu-devel] [PATCH 3/6] qcow2: flush caches in qcow2_alloc_bytes(), Stefan Hajnoczi, 2013/02/19
- [Qemu-devel] [PATCH 6/6] qcow2: drop unnecessary flush in qcow2_update_snapshot_refcount(), Stefan Hajnoczi, 2013/02/19
- Re: [Qemu-devel] [PATCH 0/6] qcow2: cache flush fixes and performance improvements, Eric Blake, 2013/02/19
- Re: [Qemu-devel] [PATCH 0/6] qcow2: cache flush fixes and performance improvements, Kevin Wolf, 2013/02/20