Re: [Qemu-devel] [PATCH 3/9] ui: add basic GTK gui (v4)

[Anthony Liguori]

Kevin Wolf <address@hidden> writes:

> On Mon, Feb 18, 2013 at 05:56:59PM -0600, Anthony Liguori wrote:
>> This is minimalistic and just contains the basic widget infrastructure.  The 
>> GUI
>> consists of a menu and a GtkNotebook.  To start with, the notebook has its 
>> tabs
>> hidden which provides a UI that looks very similar to SDL with the exception 
>> of
>> the menu bar.
>> 
>> The menu bar allows a user to toggle the visibility of the tabs.  Cairo is 
>> used
>> for rendering.
>> 
>> I used gtk-vnc as a reference.  gtk-vnc solves the same basic problems as 
>> QEMU
>> since it was originally written as a remote display for QEMU.  So for the 
>> most
>> part, the approach to rendering and keyboard handling should be pretty solid 
>> for
>> GTK.
>> 
>> Signed-off-by: Anthony Liguori <address@hidden>
>> diff --git a/configure b/configure
>> index 74d5878..b0595b1 100755
>> --- a/configure
>> +++ b/configure
>> @@ -1636,6 +1636,23 @@ if test "$sparse" != "no" ; then
>>  fi
>>  
>>  ##########################################
>> +# GTK probe
>> +
>> +if test "$gtk" != "no"; then
>> +    if $pkg_config gtk+-2.0 --modversion >/dev/null 2>/dev/null && \
>> +       $pkg_config vte --modversion >/dev/null 2>/dev/null; then
>> +    gtk_cflags=`$pkg_config --cflags gtk+-2.0 2>/dev/null`
>> +    gtk_libs=`$pkg_config --libs gtk+-2.0 2>/dev/null`
>> +    vte_cflags=`$pkg_config --cflags vte 2>/dev/null`
>> +    vte_libs=`$pkg_config --libs vte 2>/dev/null`
>> +    libs_softmmu="$gtk_libs $vte_libs $libs_softmmu"
>> +    gtk="yes"
>> +    else
>> +    gtk="no"
>> +    fi
>> +fi
>> +
>> +##########################################
>>  # SDL probe
>>  
>>  # Look for sdl configuration program (pkg-config or sdl-config).  Try
>> @@ -3301,6 +3318,7 @@ if test "$darwin" = "yes" ; then
>>  fi
>>  echo "pixman            $pixman"
>>  echo "SDL support       $sdl"
>> +echo "GTK support       $gtk"
>>  echo "curses support    $curses"
>>  echo "curl support      $curl"
>>  echo "mingw32 support   $mingw32"
>> @@ -3591,6 +3609,11 @@ if test "$bluez" = "yes" ; then
>>    echo "BLUEZ_CFLAGS=$bluez_cflags" >> $config_host_mak
>>  fi
>>  echo "GLIB_CFLAGS=$glib_cflags" >> $config_host_mak
>> +if test "$gtk" = "yes" ; then
>> +  echo "CONFIG_GTK=y" >> $config_host_mak
>> +  echo "GTK_CFLAGS=$gtk_cflags" >> $config_host_mak
>> +  echo "VTE_CFLAGS=$vte_cflags" >> $config_host_mak
>> +fi
>>  if test "$xen" = "yes" ; then
>>    echo "CONFIG_XEN_BACKEND=y" >> $config_host_mak
>>    echo "CONFIG_XEN_CTRL_INTERFACE_VERSION=$xen_ctrl_version" >> 
>> $config_host_mak
>
> Why is there no explicit --enable/disable-gtk like for most (all?)
> other options?

Looks like an oversight, will fix.  Thanks.

Regards,

Anthony Liguori

>
> Kevin