[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v10 2/3] pl330: Initial version
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH v10 2/3] pl330: Initial version |
|
Date: |
Tue, 19 Feb 2013 17:53:58 +0000 |
On 19 February 2013 17:44, Igor Mitsyanko <address@hidden> wrote:
> On 02/19/2013 11:46 AM, Peter Crosthwaite wrote:
>>
>> Device model for Primecell PL330 DMA controller.
>>
>> Signed-off-by: Peter Crosthwaite <address@hidden>
>> Signed-off-by: Kirill Batuzov <address@hidden>
>> Tested-by: Igor Mitsyanko <address@hidden>
>
>
> Is my reviewed-by required if it already has my tested-by? I have a few
> minor comments bellow and then you can add my reviewed-by tag if you want.
They mean different things (both worth noting):
Tested-by means you ran the code and it did the right thing
Reviewed-by means you read the code and it looks good
-- PMM