qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v10 2/3] pl330: Initial version


From: Igor Mitsyanko
Subject: Re: [Qemu-devel] [PATCH v10 2/3] pl330: Initial version
Date: Tue, 19 Feb 2013 22:02:23 +0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2


On 02/19/2013 09:53 PM, Peter Maydell wrote:
On 19 February 2013 17:44, Igor Mitsyanko <address@hidden> wrote:
On 02/19/2013 11:46 AM, Peter Crosthwaite wrote:
Device model for Primecell PL330 DMA controller.

Signed-off-by: Peter Crosthwaite <address@hidden>
Signed-off-by: Kirill Batuzov <address@hidden>
Tested-by: Igor Mitsyanko <address@hidden>

Is my reviewed-by required if it already has my tested-by? I have a few
minor comments bellow and then you can add my reviewed-by tag if you want.
They mean different things (both worth noting):
Tested-by means you ran the code and it did the right thing
Reviewed-by means you read the code and it looks good

I thought reviewed-by implied tested-by) I'll add this tag to a next patch version then.


-- PMM


--
Mitsyanko Igor
ASWG, Moscow R&D center, Samsung Electronics
email: address@hidden




reply via email to

[Prev in Thread] Current Thread [Next in Thread]