qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] vga: fix byteswapping.


From: Mark Cave-Ayland
Subject: Re: [Qemu-devel] [PATCH] vga: fix byteswapping.
Date: Tue, 19 Feb 2013 20:20:56 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12

On 18/02/13 10:31, Gerd Hoffmann wrote:

In case host and guest endianness differ the vga code first creates
a shared surface (using qemu_create_displaysurface_from), then goes
patch the surface format to indicate that the bytes must be swapped.

The switch to pixman broke that hack as the format patching isn't
propagated into the pixman image, so ui code using the pixman image
directly (such as vnc) uses the wrong format.

Fix that by adding a byteswap parameter to
qemu_create_displaysurface_from, so we'll use the correct format
when creating the surface (and the pixman image) and don't have
to patch the format afterwards.

Cc: address@hidden
Cc: address@hidden
Cc: address@hidden
Signed-off-by: Gerd Hoffmann<address@hidden>

Hi Gerd,

I can confirm that this patch against git master appears to solve the problem for me on qemu-system-ppc - many thanks! So I guess now it's just pending a fix for the Xen build before it can be applied?


ATB,

Mark.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]