Re: [Qemu-devel] [PATCH V6 02/14] block: add bdrv_can_read_snapshot() function

[Eric Blake]

On 02/18/2013 07:09 AM, Wenchao Xia wrote:
>   Compared to bdrv_can_snapshot(), this function return whether
> bs* is ready to read snapshot info from instead of write. If yes,
> caller can then query snapshot information, but taking snapshot
> is not always possible for that *bs may be read only.
> 
> Signed-off-by: Wenchao Xia <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>

Per the cover letter, you modified this patch in v6 by changing a return
type from int to bool.  In general, a reviewed-by should be dropped if
your changes were non-trivial, to point out that the reviewer needs to
look at the updated patch (after all, if there were existing callers,
changing from int to bool can change semantics of some of those existing
callers).  Thankfully, for this patch, v6 still earns:

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature