qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V6 03/14] block: return bool for bdrv_can_snapsh


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH V6 03/14] block: return bool for bdrv_can_snapshot()
Date: Tue, 19 Feb 2013 13:48:55 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2

On 02/18/2013 07:09 AM, Wenchao Xia wrote:
>   This function should return bool instead of int, just as
> bdrv_can_read_snapshot().
> 
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
>  block.c               |    8 ++++----
>  include/block/block.h |    2 +-
>  2 files changed, 5 insertions(+), 5 deletions(-)

I checked that all existing callers only used the function in a boolean
context.

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]