[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 2/6] a9mpcore: localised temporary init-only
|
From: |
Peter Crosthwaite |
|
Subject: |
Re: [Qemu-devel] [PATCH v1 2/6] a9mpcore: localised temporary init-only variables |
|
Date: |
Wed, 20 Feb 2013 10:23:00 +1000 |
On Tue, Feb 19, 2013 at 4:12 AM, Peter Maydell <address@hidden> wrote:
> On 8 February 2013 04:03, Peter Crosthwaite
> <address@hidden> wrote:
>> The DeviceState *mptimer var in a9mp_priv_state was only used by the init
>> function and had no reason for persistence. Made a local variable and removed
>> from state struct.
>
> Nope. We're a container object, we can't just forget about our
> children. Granted (like many QEMU devices) we don't actually have
> any implementation of device destruction, but in principle we
> need to keep hold of a pointer to the things we create.
>
Patch dropped pending resolution of QOM container inline-struct discussion.
Regards,
Peter
> -- PMM
>