Re: [Qemu-devel] [PATCH 1/9] build: disable Wstrict-prototypes

[Kevin Wolf]

On Mon, Feb 18, 2013 at 05:56:57PM -0600, Anthony Liguori wrote:
> GTK won't build with strict-prototypes due to gtkitemfactory.h:
> 
>     /* We use () here to mean unspecified arguments. This is deprecated
>      * as of C99, but we can't change it without breaking compatibility.
>      * (Note that if we are included from a C++ program () will mean
>      * (void) so an explicit cast will be needed.)
>      */
>     typedef   void    (*GtkItemFactoryCallback)  ();
> 
> Signed-off-by: Anthony Liguori <address@hidden>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index bf5970f..74d5878 100755
> --- a/configure
> +++ b/configure
> @@ -283,7 +283,7 @@ sdl_config="${SDL_CONFIG-${cross_prefix}sdl-config}"
>  # default flags for all hosts
>  QEMU_CFLAGS="-fno-strict-aliasing $QEMU_CFLAGS"
>  QEMU_CFLAGS="-Wall -Wundef -Wwrite-strings -Wmissing-prototypes $QEMU_CFLAGS"
> -QEMU_CFLAGS="-Wstrict-prototypes -Wredundant-decls $QEMU_CFLAGS"
> +QEMU_CFLAGS="-Wredundant-decls $QEMU_CFLAGS"
>  QEMU_CFLAGS="-D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE 
> $QEMU_CFLAGS"
>  QEMU_INCLUDES="-I. -I\$(SRC_PATH) -I\$(SRC_PATH)/include"
>  if test "$debug_info" = "yes"; then

Other places wrap the inclusion of problematic headers in '#pragma GCC
diagnostic ...' instead of globally disabling warnings.

Kevin